Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow TLS provider to use versions 3.0+ (i.e. - >= 3.0) #2211

Merged
merged 1 commit into from
Aug 26, 2022
Merged

feat: Allow TLS provider to use versions 3.0+ (i.e. - >= 3.0) #2211

merged 1 commit into from
Aug 26, 2022

Conversation

KarstenSiemer
Copy link
Contributor

Description

In #2174 the tls provider was pinned to ~> 3.0 because of hashicorp/terraform-provider-tls#244,
of which the corresponding problem was fixed in 4.0.1 of the provider according to the maintainer, which I can confirm.

This PR will upgrade the tls provider to the version which includes the fix.

Motivation and Context

This is required, since we should look forward to being as up to date as possible and to prohibit any provider errors, because
a lot of modules have already upgraded to 4x.

Breaking Changes

None, that I can think of.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

bryantbiggs commented Aug 25, 2022 •
edited
Loading

if we enforce 4.x as the minimum version, then that falls under a breaking change. but if we can change ~> 3.0 to >= 3.0 then that we could support today without a breaking change

@KarstenSiemer KarstenSiemer force-pushed the feat/upgrade-tls-provider-to-4.0.1 branch 2 times, most recently from 3637698 to 4aa954c Compare August 25, 2022 17:21
@KarstenSiemer
Copy link
Contributor Author

@bryantbiggs thanks for the suggestion. I have updated the commit

@bryantbiggs
Copy link
Member

apologies - I made a typo, see the updated comment above

@KarstenSiemer KarstenSiemer force-pushed the feat/upgrade-tls-provider-to-4.0.1 branch from 4aa954c to bac1d9d Compare August 25, 2022 17:24
@KarstenSiemer KarstenSiemer force-pushed the feat/upgrade-tls-provider-to-4.0.1 branch from bac1d9d to f71e74c Compare August 25, 2022 17:25
@KarstenSiemer KarstenSiemer changed the title feat: upgrade tls provider to 4.0.1 feat: Upgrade tls provider to >= 3.0 Aug 25, 2022
@KarstenSiemer
Copy link
Contributor Author

@bryantbiggs no, worries. I was a little confused but decided to trust 😂
Hope it is fine now

@KarstenSiemer
Copy link
Contributor Author

Do you think we can merge this soon and publish a new version?

bryantbiggs
bryantbiggs approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs changed the title feat: Upgrade tls provider to >= 3.0 feat: Allow TLS provider to use versions 3.0+ (i.e. - >= 3.0) Aug 26, 2022
@bryantbiggs bryantbiggs merged commit f576a6f into terraform-aws-modules:master Aug 26, 2022
antonbabenko pushed a commit that referenced this pull request Aug 26, 2022
@semantic-release-bot
chore(release): version 18.29.0 [skip ci]
4ca9187 
## [18.29.0](v18.28.0...v18.29.0) (2022-08-26)

### Features

* Allow TLS provider to use versions 3.0+ (i.e. - `>= 3.0`) ([#2211](#2211)) ([f576a6f](f576a6f))
@antonbabenko
Copy link
Member

This PR is included in version 18.29.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarstenSiemer @bryantbiggs @antonbabenko