Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow configuring which tags are passed on launch template tag specifications #2360

Merged
merged 2 commits into from
Dec 19, 2022
Merged

feat: Allow configuring which tags are passed on launch template tag specifications #2360

merged 2 commits into from
Dec 19, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Dec 19, 2022 •
edited
Loading

Description

  • Allow configuring which tags are passed on launch template tag specifications

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member Author

Since the tagging of the elastic GPUs seems to be the problematic scenario - I am reverting that from the list of defaults and users will need to opt in to tag those

antonbabenko
antonbabenko approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@bryantbiggs bryantbiggs merged commit 094ed1d into terraform-aws-modules:master Dec 19, 2022
@bryantbiggs bryantbiggs deleted the fix/launch-template-tags branch December 19, 2022 18:50
antonbabenko pushed a commit that referenced this pull request Dec 19, 2022
@semantic-release-bot
chore(release): version 19.4.0 [skip ci]
ee49507 
## [19.4.0](v19.3.1...v19.4.0) (2022-12-19)

### Features

* Allow configuring which tags are passed on launch template tag specifications ([#2360](#2360)) ([094ed1d](094ed1d))
@antonbabenko
Copy link
Member

This PR is included in version 19.4.0 🎉

@gamunu
Copy link

gamunu commented Dec 19, 2022 •
edited
Loading

@antonbabenko probably better to remove spot-instances-request from the list as well. Ireland region does not support spot tagging, just verified the new version.

@jurgen-weber-deltatre
Copy link

Thank you for the quick resolution

@pavlospt
Copy link
Contributor

Indeed spot request should be excluded as well!

@cw-juyeonyu
Copy link

Thank you~~~ 🌟

@pavlospt pavlospt mentioned this pull request Dec 20, 2022
Merged
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jan 4, 2023
@bryantbiggs @spr-mweber3
feat: Allow configuring which tags are passed on launch template tag …
2463381 
…specifications (terraform-aws-modules#2360)

Resolves undefined
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jan 4, 2023
@semantic-release-bot @spr-mweber3
chore(release): version 19.4.0 [skip ci]
3d3e32c 
## [19.4.0](terraform-aws-modules/terraform-aws-eks@v19.3.1...v19.4.0) (2022-12-19)

### Features

* Allow configuring which tags are passed on launch template tag specifications ([terraform-aws-modules#2360](terraform-aws-modules#2360)) ([094ed1d](terraform-aws-modules@094ed1d))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@bryantbiggs @antonbabenko @gamunu @jurgen-weber-deltatre @pavlospt @cw-juyeonyu