Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version for kubernetes provider across examples to exactly 1.10.0 #735

Merged
merged 11 commits into from
Feb 27, 2020

Conversation

bjmask
Copy link
Contributor

@bjmask bjmask commented Feb 11, 2020

PR o'clock

Description

Semantic version fails on latest kubernetes provider, pinning the version on examples exactly to 1.10.0 resolves many issues

Please explain the changes you made here and link to any relevant issues.

Checklist

Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andres-de-castro Thanks for opening this. Can you please update the changelog ?

README.md Outdated Show resolved Hide resolved
@bjmask
Copy link
Contributor Author

bjmask commented Feb 11, 2020

@andres-de-castro Thanks for opening this. Can you please update the changelog ?

For 8.0.1 ?

@barryib
Copy link
Member

barryib commented Feb 12, 2020

@andres-de-castro Thanks for opening this. Can you please update the changelog ?

For 8.0.1 ?

https:/terraform-aws-modules/terraform-aws-eks/blob/master/CHANGELOG.md#v8---2020-xx-xx

@bjmask
Copy link
Contributor Author

bjmask commented Feb 14, 2020

@andres-de-castro Thanks for opening this. Can you please update the changelog ?

For 8.0.1 ?

https:/terraform-aws-modules/terraform-aws-eks/blob/master/CHANGELOG.md#v8---2020-xx-xx

good to go!

@bjmask bjmask requested a review from barryib February 14, 2020 18:47
Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andres-de-castro

@max-rocket-internet max-rocket-internet merged commit dda2449 into terraform-aws-modules:master Feb 27, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants