Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ip address when manage_aws_auth is true and public_access is false #745

Merged
merged 19 commits into from
Mar 19, 2020

Conversation

slimm609
Copy link
Contributor

@slimm609 slimm609 commented Feb 20, 2020

PR o'clock

Description

in issue #744, the cluster does not finish configuration when manage_aws_auth = true and cluster_endpoint_public_access = false because there is no access to the cluster endpoint.

This PR authorizes a CIDR to access the cluster to be able to finish the setup.

Checklist

variables.tf Outdated Show resolved Hide resolved
cluster.tf Outdated Show resolved Hide resolved
cluster.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slimm609

@max-rocket-internet
Copy link
Contributor

@slimm609 you have a lint error

@slimm609
Copy link
Contributor Author

fixed

@mag009
Copy link

mag009 commented Mar 11, 2020

when will this change be released ?

CHANGELOG.md Outdated Show resolved Hide resolved
cluster.tf Outdated Show resolved Hide resolved
@slimm609
Copy link
Contributor Author

changes made

@slimm609 slimm609 requested a review from barryib March 13, 2020 15:28
@b2cbre
Copy link
Contributor

b2cbre commented Mar 17, 2020

@slimm609 thank you for working on this. Perhaps addressing the merge conflict and squashing the commits will drive this PR forward.

@slimm609 slimm609 changed the title add ip address when manage_aws_auth is true and public_access is false BUG: add ip address when manage_aws_auth is true and public_access is false Mar 18, 2020
@slimm609 slimm609 changed the title BUG: add ip address when manage_aws_auth is true and public_access is false bug: add ip address when manage_aws_auth is true and public_access is false Mar 18, 2020
@slimm609 slimm609 changed the title bug: add ip address when manage_aws_auth is true and public_access is false fix: add ip address when manage_aws_auth is true and public_access is false Mar 18, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants