Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add node_group direct dependency on eks_cluster #796

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

dpiddockcmp
Copy link
Contributor

@dpiddockcmp dpiddockcmp commented Mar 14, 2020

PR o'clock

Description

Setting manage_aws_auth = false removes the ordering dependency between node_group and eks_cluster generating an error on first apply. This change ensures that the eks_cluster is created before trying to create the node_group.

Fixes #793

Checklist

Setting `manage_aws_auth = false` removes the ordering dependency
between node_group and eks_cluster generating an error on first apply.
This fixes that use case.
Fixes #793
@dpiddockcmp dpiddockcmp changed the title Add node_group direct dependency on eks_cluster fix: Add node_group direct dependency on eks_cluster Mar 17, 2020
@barryib barryib merged commit 89401f1 into terraform-aws-modules:master Mar 18, 2020
@dpiddockcmp dpiddockcmp deleted the fix/793 branch March 18, 2020 09:28
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants