Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert removal of templates provider #883

Merged
merged 5 commits into from
Jun 5, 2020
Merged

fix: Revert removal of templates provider #883

merged 5 commits into from
Jun 5, 2020

Conversation

dpiddockcmp
Copy link
Contributor

PR o'clock

Description

Revert removing the templates provider. It broke some workflows due to previously being able to pass in the raw contents of a template file for processing.

Unfortunately the Terraform built in templatefile() function requires use with a file that exists before running the plan. So we're stuck with using template_file data source and all the obnoxious random updates it causes for now.

Fixes #882

Checklist

@dpiddockcmp dpiddockcmp mentioned this pull request May 15, 2020
Closed
4 tasks
@mbarrien
Copy link
Contributor

Ping? I'm still stuck pinning both this version and the Terraform AWS provider version because this regression is included in the same release as #875 which I need sooner than later. Trying to avoid forking this module just to be able to get #875 because I'm feeling the pain right now (needing some fixes in more recent AWS providers in unrelated areas). It'll be a LONG time before 0.13.0 final is out (it's unacceptable to force us to use a beta version) and just waiting months for the fix is not acceptable.

If #875 were in a separate version, I would've pinned on that, but since these 2 are tied together, I can't.

@barryib barryib removed the on hold label May 29, 2020
@barryib
Copy link
Member

barryib commented May 29, 2020

@dpiddockcmp @mbarrien I'm going to test this. Sorry for the delay. A week off without internet.

barryib
barryib approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dpiddockcmp, you can merge it when you're ready.

@dpiddockcmp dpiddockcmp merged commit 7de18cd into terraform-aws-modules:master Jun 5, 2020
@dpiddockcmp dpiddockcmp deleted the fix/882 branch June 5, 2020 08:34
@jamiebuxxx jamiebuxxx mentioned this pull request Jun 9, 2020
Closed
4 tasks
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
@dpiddockcmp
fix: Revert removal of templates provider (terraform-aws-modules#883)
1d67109 
Broke use case of passing in custom template content. Reverts most of the following PRs:
- terraform-aws-modules#865
- terraform-aws-modules#863 
- terraform-aws-modules#854
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barryib barryib barryib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

12.0.0 broke userdata_template_file in worker_groups
4 participants
@dpiddockcmp @mbarrien @barryib @dpiddock