fix: Add egress rule update support #107
Conversation
|
Hi @antonbabenko, Is there any chance we could get this approved and merged? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Commenting to remove stale mark. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Commenting to remove stale mark. |
There was a problem hiding this comment.
Let's make this change not as a breaking change.
Add support for ip_address variable like now; keep subnet_ids as before.
In for_each try to use ip_address (if not empty) or subnet_ids converted in the same structure as ip_address.
Make sure to show the usage of both variables in examples.
## [4.0.1](v4.0.0...v4.0.1) (2024-08-31) ### Bug Fixes * Add egress rule update support ([#107](#107)) ([bbcab64](bbcab64))
|
This PR is included in version 4.0.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR complements #106 by adding a new variable, allowing the submodule to update egress rules. This PR also adds support for setting static IP address on the resolver endpoint instances.
Motivation and Context
The previous pull request was hardcoding an egress rule allowing All the traffic. Users could want to update these rules as their needs.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request