Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacing deprecated set-output to use env instead #94

Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix: replacing deprecated set-output to use env instead #94

merged 1 commit into from
Nov 9, 2022

Conversation

tobiasehlert
Copy link
Contributor

Description of your changes

Replacing deprecated set-output to use env $GITHUB_OUTPUT instead.

Blogg post about deprecation:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I have:

  • Read and followed terraform-docs' [contribution process].

@tobiasehlert tobiasehlert changed the title Replacing deprecated set-output to use env instead fix: replacing deprecated set-output to use env instead Oct 19, 2022
@cocallaw
Copy link

cocallaw commented Nov 3, 2022

@metmajer or @khos2ow any update on getting this PR reviewed and approved?

@chrisdleech-pol
Copy link

It would be super lovely if this PR was approved and merged

@cocallaw
Copy link

cocallaw commented Nov 7, 2022

This PR addresses issues #92 and #95

@khos2ow khos2ow linked an issue Nov 9, 2022 that may be closed by this pull request
Copy link
Member

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tobiasehlert and sorry for the very long delay getting back to this! Your change looks good to me, but it appears the whole repo needs some love. I'm gonna merge your PR as is and will fix the issues on another PR.

@khos2ow khos2ow merged commit cfde42f into terraform-docs:main Nov 9, 2022
@tobiasehlert tobiasehlert deleted the patch-1 branch November 11, 2022 11:51
@MitchellPaff
Copy link

MitchellPaff commented Mar 24, 2023

Thanks for the fix - would be good to tag a release, so downstream projects aren't at risk of failing on May31st. Thanks!

@LumixximuL
Copy link

@khos2ow is there any progress on the repo updates here? Looks like we've got about 2 weeks left and this will begin blocking pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set-output is deprecated
8 participants