Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_kinesis_stream: Add support for encryption #1139

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 13, 2017

Fixes: #1109

Got an issue with StopEncryption - working on this atm

@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 13, 2017
@ungureanuvladvictor
Copy link
Contributor

Any update on this?

@aggallim
Copy link

+1, any updates?

@Ninir
Copy link
Contributor

Ninir commented Aug 17, 2017

Hey @stack72

Are you still having issues with the StopEncryption thing?
Do you think you would have time to finish that if not?

Thanks!

@Ninir Ninir added the waiting-response Maintainers are waiting on response from community or contributor. label Aug 17, 2017
@stack72
Copy link
Contributor Author

stack72 commented Aug 28, 2017

@Ninir if you want, we can jump on a call at some point and i can show you the issues I am having with this :)

@Ninir
Copy link
Contributor

Ninir commented Aug 28, 2017

Hi Paul!

Sure, if I can be of any help... 😄 🤷‍♂️ !

@Ninir Ninir removed the waiting-response Maintainers are waiting on response from community or contributor. label Aug 28, 2017
@ungureanuvladvictor
Copy link
Contributor

Bump on this one!

@tombuildsstuff tombuildsstuff force-pushed the kinesis-stream-sse branch 2 times, most recently from 0d4f446 to 10e5ba6 Compare September 9, 2017 16:29
@Ninir
Copy link
Contributor

Ninir commented Sep 11, 2017

@stack72 Do you want to hangout / Skype / other? :)

@stack72
Copy link
Contributor Author

stack72 commented Sep 11, 2017 via email

@Ninir
Copy link
Contributor

Ninir commented Sep 11, 2017

Thanks for that @stack72 !

(Could you indicate me a way to contact you for a quick chat? Gitter / other? thanks!)

@stack72 stack72 changed the title [WIP] resource/aws_kinesis_stream: Add support for encryption resource/aws_kinesis_stream: Add support for encryption Sep 11, 2017
@stack72
Copy link
Contributor Author

stack72 commented Sep 11, 2017

@Ninir i can log into gitter - also, the acceptance tests for this were run via teamcity

@gdearment
Copy link

Any updates on when this might go through?

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just fixed a wrong field name in a separate commit, otherwise this LGTM, merging... 🚀

@radeksimko radeksimko merged commit 0befe65 into master Oct 5, 2017
@radeksimko radeksimko deleted the kinesis-stream-sse branch October 5, 2017 15:17
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Server side encryption for aws_kinesis_stream
6 participants