Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/codeartifact_domain_permissions_policy - new resource #13753

Merged
merged 10 commits into from
Oct 1, 2020
Merged

r/codeartifact_domain_permissions_policy - new resource #13753

merged 10 commits into from
Oct 1, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 15, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13714 , Depends on #13743

Release note for CHANGELOG:

resource_aws_codeartifact_domain_permissions - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissions_'
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_basic (353.49s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_owner (50.41s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears (44.62s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain (44.07s)

@DrFaust92 DrFaust92 requested a review from a team June 15, 2020 07:34
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 15, 2020
@ewbankkit
Copy link
Contributor

I suggest renaming the resource to aws_codeartifact_domain_permissions_policy (and hence renaming the source files and functions) as this is the name in the AWS API.

@ewbankkit
Copy link
Contributor

ewbankkit commented Jul 17, 2020 •
edited
Loading

Validated acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomainPermissions_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomainPermissions_basic
=== PAUSE TestAccAWSCodeArtifactDomainPermissions_basic
=== RUN   TestAccAWSCodeArtifactDomainPermissions_disappears
=== PAUSE TestAccAWSCodeArtifactDomainPermissions_disappears
=== CONT  TestAccAWSCodeArtifactDomainPermissions_basic
=== CONT  TestAccAWSCodeArtifactDomainPermissions_disappears
--- PASS: TestAccAWSCodeArtifactDomainPermissions_disappears (28.04s)
--- PASS: TestAccAWSCodeArtifactDomainPermissions_basic (31.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.441s

I suggest also adding a test which deletes the domain

testAccCheckResourceDisappears(testAccProvider, resourceAwsCodeArtifactDomain(), resourceName),

and verifies a non-empty plan.

@DrFaust92 DrFaust92 force-pushed the f-codeartifact-domain-permission branch from 78ffba5 to d333917 Compare July 19, 2020 18:57
@DrFaust92 DrFaust92 force-pushed the f-codeartifact-domain-permission branch from 2058b3e to 3e952ef Compare July 31, 2020 16:09
@DrFaust92 DrFaust92 changed the title [WIP]r/codeartifact_domain_permissions - new resource [WIP]r/codeartifact_domain_permissions_policy - new resource Jul 31, 2020
@DrFaust92 DrFaust92 force-pushed the f-codeartifact-domain-permission branch from 1b9d83c to c6999a1 Compare August 24, 2020 14:16
@DrFaust92 DrFaust92 force-pushed the f-codeartifact-domain-permission branch from 266edf0 to 7a90ac3 Compare September 30, 2020 23:11
@DrFaust92 DrFaust92 changed the title [WIP]r/codeartifact_domain_permissions_policy - new resource r/codeartifact_domain_permissions_policy - new resource Sep 30, 2020
ewbankkit
ewbankkit reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissionsPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomainPermissionsPolicy_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
    resource_aws_codeartifact_domain_permissions_policy_test.go:86: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
    resource_aws_codeartifact_domain_permissions_policy_test.go:107: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain (27.63s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears (28.08s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_owner (30.61s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_basic (44.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.816s

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissionsPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomainPermissionsPolicy_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
    resource_aws_codeartifact_domain_permissions_policy_test.go:107: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
    resource_aws_codeartifact_domain_permissions_policy_test.go:86: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain (16.69s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears (18.57s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_owner (18.96s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_basic (30.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.408s

@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@breathingdust breathingdust merged commit 475dcec into hashicorp:master Oct 1, 2020
breathingdust added a commit that referenced this pull request Oct 1, 2020
@breathingdust
Update CHANGELOG for #13753
3c24359
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
@DrFaust92 DrFaust92 deleted the f-codeartifact-domain-permission branch February 12, 2022 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @ewbankkit @breathingdust