ensuring the ID for kms_secrets is deterministic

[jurgenweber]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14579
Relates #15399
Relates #14564

Release note for CHANGELOG:

Notes:
* data-source/aws_kms_secrets: The `id` attribute has changed to the name of the AWS Region. The first apply of this updated data source may show this difference.

Fixes:
* data-source/aws_kms_secrets: Prevent plan differences with the `id` attribute

Output from acceptance testing:

--- PASS: TestAccAWSKmsSecretsDataSource_basic (65.69s)


...

On TF Cloud this is super annoying, as TFCloud thinks there is a change and does not auto resolve the plan... That mean every plan even when there are no changes either need to be manually applied or discarded.

I took inspiration from this PR: #15399

Thanks

[jurgenweber]

@ewbankkit 👍

[bflad]

Thank you for fixing this, @jurgenweber 🚀

[jurgenweber]

@bflad my pleasure!

[ghost]

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!