resource/aws_appautoscaling_policy: Support additional predefined metric types in validation #3122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3112
Validation of the attributes for
aws_appautoscaling_policy
has been a mixed bag of requests for the validation at plan time and issues like this where the validation is not up to date. Ideally, we would perform some type of compile time reflection of theseapplicationautoscaling.MetricType*
constants instead, but this at least brings us up to all the currently supported predefined metrics types and adds unit testing.