issue #4857 Can't use spot instances with aws_launch_template

[saravanan30erd]

Fixes #4857

Changes proposed in this pull request:

• Change 1:

By default, if we didn't mention the valid_until option in config then the default end date is 7 days from the current date.
But I was getting the below error if I didn't mention the valid_until option.

• aws_launch_template.foo: Error Parsing Launch Template Spot Options valid until: parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006"

Implemented the value validation before referencing the value.

• Change 2:

If I mention the valid_until to some valid value 2020-11-04T20:44:20.000Z, then I was getting the below error(state)

• aws_launch_template.foo: instance_market_options.0.spot_options.0.valid_until: '' expected type 'string', got unconvertible type 'time.Time'

Formatting the value before setting it to state.

[felipe-vvoosh]

Nice one!

[bflad]

Thanks @saravanan30erd! 🚀

In this case Computed: true seems appropriate.

7 tests passed (all tests)
=== RUN   TestAccAWSLaunchTemplate_data
--- PASS: TestAccAWSLaunchTemplate_data (7.02s)
=== RUN   TestAccAWSLaunchTemplate_basic
--- PASS: TestAccAWSLaunchTemplate_basic (7.16s)
=== RUN   TestAccAWSLaunchTemplate_importData
--- PASS: TestAccAWSLaunchTemplate_importData (7.84s)
=== RUN   TestAccAWSLaunchTemplate_importBasic
--- PASS: TestAccAWSLaunchTemplate_importBasic (7.86s)
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (8.77s)
=== RUN   TestAccAWSLaunchTemplate_update
--- PASS: TestAccAWSLaunchTemplate_update (11.77s)
=== RUN   TestAccAWSLaunchTemplate_tags
--- PASS: TestAccAWSLaunchTemplate_tags (12.21s)

[bflad]

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!