Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_glue_crawler: Support DynamoDB targets #5152

Merged
merged 1 commit into from
Jul 26, 2018
Merged

resource/aws_glue_crawler: Support DynamoDB targets #5152

merged 1 commit into from
Jul 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 11, 2018

Closes #5151

Changes proposed in this pull request:

  • Add dynamodb_target argument to aws_glue_crawler resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCrawler'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCrawler -timeout 120m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (39.50s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (35.23s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (37.73s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (47.33s)
=== RUN   TestAccAWSGlueCrawler_S3Target
--- PASS: TestAccAWSGlueCrawler_S3Target (35.74s)
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (36.40s)
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (46.11s)
=== RUN   TestAccAWSGlueCrawler_Classifiers
--- PASS: TestAccAWSGlueCrawler_Classifiers (40.93s)
=== RUN   TestAccAWSGlueCrawler_Configuration
--- PASS: TestAccAWSGlueCrawler_Configuration (36.57s)
=== RUN   TestAccAWSGlueCrawler_Description
--- PASS: TestAccAWSGlueCrawler_Description (35.28s)
=== RUN   TestAccAWSGlueCrawler_Schedule
--- PASS: TestAccAWSGlueCrawler_Schedule (36.86s)
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (35.60s)
=== RUN   TestAccAWSGlueCrawler_TablePrefix
--- PASS: TestAccAWSGlueCrawler_TablePrefix (37.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	500.622s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. labels Jul 11, 2018
@bflad bflad requested a review from a team July 11, 2018 13:53
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 11, 2018
@bflad bflad mentioned this pull request Jul 11, 2018
Closed
catsby
catsby approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@bflad bflad added this to the v1.30.0 milestone Jul 26, 2018
@bflad bflad merged commit 655b9d6 into master Jul 26, 2018
@bflad bflad deleted the f-aws_glue_crawler-dynamodb_target branch July 26, 2018 18:12
bflad added a commit that referenced this pull request Jul 26, 2018
@bflad
Update CHANGELOG for #5152
5dc6619
@bflad
Copy link
Contributor Author

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Add DynamoDB Target to Glue Crawler Resource
2 participants
@bflad @catsby