Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_storagegateway_local_disk: Add disk_node argument #5595

Merged
merged 1 commit into from
Aug 20, 2018
Merged

data-source/aws_storagegateway_local_disk: Add disk_node argument #5595

merged 1 commit into from
Aug 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 17, 2018

Reference: #5589

Changes proposed in this pull request:

  • Support optional disk_node argument, which can represent the device node
  • Mark disk_path argument as optional and clarify usage

Output from acceptance testing:

--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskNode (214.08s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath (226.07s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Aug 17, 2018
@bflad bflad requested a review from a team August 17, 2018 16:43
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 17, 2018
@bflad bflad mentioned this pull request Aug 17, 2018
Closed
mbfrahry
mbfrahry approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v1.33.0 milestone Aug 20, 2018
@bflad bflad merged commit cabe247 into master Aug 20, 2018
@bflad bflad deleted the f-aws_storagegateway_local_disk-disk_node branch August 20, 2018 20:01
bflad added a commit that referenced this pull request Aug 20, 2018
@bflad
Update CHANGELOG for #5595
066db6f
@bflad
Copy link
Contributor Author

bflad commented Aug 22, 2018

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @mbfrahry