Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_job: Support security_configuration property #6232

Merged
merged 1 commit into from
Oct 26, 2018
Merged

resource/aws_glue_job: Support security_configuration property #6232

merged 1 commit into from
Oct 26, 2018

Conversation

matthewswain
Copy link
Contributor

Fixes #6099

Changes proposed in this pull request:

  • Add support for the security_configuration property on Glue jobs.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueJob'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGlueJob -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSGlueJob_Basic
=== PAUSE TestAccAWSGlueJob_Basic
=== RUN   TestAccAWSGlueJob_AllocatedCapacity
=== PAUSE TestAccAWSGlueJob_AllocatedCapacity
=== RUN   TestAccAWSGlueJob_Command
=== PAUSE TestAccAWSGlueJob_Command
=== RUN   TestAccAWSGlueJob_DefaultArguments
=== PAUSE TestAccAWSGlueJob_DefaultArguments
=== RUN   TestAccAWSGlueJob_Description
=== PAUSE TestAccAWSGlueJob_Description
=== RUN   TestAccAWSGlueJob_ExecutionProperty
=== PAUSE TestAccAWSGlueJob_ExecutionProperty
=== RUN   TestAccAWSGlueJob_MaxRetries
=== PAUSE TestAccAWSGlueJob_MaxRetries
=== RUN   TestAccAWSGlueJob_Timeout
=== PAUSE TestAccAWSGlueJob_Timeout
=== RUN   TestAccAWSGlueJob_SecurityConfiguration
=== PAUSE TestAccAWSGlueJob_SecurityConfiguration
=== CONT  TestAccAWSGlueJob_Basic
=== CONT  TestAccAWSGlueJob_ExecutionProperty
=== CONT  TestAccAWSGlueJob_DefaultArguments
=== CONT  TestAccAWSGlueJob_SecurityConfiguration
=== CONT  TestAccAWSGlueJob_Command
=== CONT  TestAccAWSGlueJob_Timeout
=== CONT  TestAccAWSGlueJob_MaxRetries
=== CONT  TestAccAWSGlueJob_AllocatedCapacity
=== CONT  TestAccAWSGlueJob_Description
--- PASS: TestAccAWSGlueJob_Timeout (36.72s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (41.07s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (43.13s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (46.15s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (46.42s)
--- PASS: TestAccAWSGlueJob_Command (47.31s)
--- PASS: TestAccAWSGlueJob_MaxRetries (48.87s)
--- PASS: TestAccAWSGlueJob_Description (54.62s)
--- PASS: TestAccAWSGlueJob_Basic (67.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.295s
...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 21, 2018
@matthewswain matthewswain changed the title Add support for security_configuration property on resource aws_glue_job. resource/aws_glue_job: Support security_configuration property Oct 21, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 26, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @matthewswain! I'm surprised that Glue allows you to submit non-existent names into there, but since the acceptance testing currently passes without us implementing a proper aws_glue_security_configuration resource, let's go ahead and get configuring! 🚀

--- PASS: TestAccAWSGlueJob_SecurityConfiguration (34.90s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.78s)
--- PASS: TestAccAWSGlueJob_Command (42.88s)
--- PASS: TestAccAWSGlueJob_Description (48.57s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (48.64s)
--- PASS: TestAccAWSGlueJob_Timeout (59.11s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (61.54s)
--- PASS: TestAccAWSGlueJob_Basic (65.07s)
--- PASS: TestAccAWSGlueJob_MaxRetries (115.02s)

@bflad bflad added this to the v1.42.0 milestone Oct 26, 2018
@bflad bflad merged commit 73dd582 into hashicorp:master Oct 26, 2018
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Configuration Support for AWS Glue Terraform
2 participants