Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resources: aws_cloudformation_stack_set and aws_cloudformation_stack_set_instance #8020

Merged
merged 3 commits into from
Mar 21, 2019
Merged

New Resources: aws_cloudformation_stack_set and aws_cloudformation_stack_set_instance #8020

merged 3 commits into from
Mar 21, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 20, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

  • New Resource: aws_cloudformation_stack_set
  • New Resource: aws_cloudformation_stack_set_instance
  • tests/resource/aws_cloudformation_stack: Ensure resource recreation when deleted outside Terraform

Output from acceptance testing:

--- PASS: TestAccAWSCloudFormationStack_disappears (69.36s)

--- PASS: TestAccAWSCloudFormationStackSet_basic (15.29s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (22.90s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (39.15s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (39.37s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (43.84s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (44.60s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (50.43s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (62.88s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (66.14s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (69.07s)

--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (116.33s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (123.01s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (131.07s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (161.53s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (225.51s)

@bflad
New Resource: aws_cloudformation_stack_set
f16dee5 
Output from acceptance testing:

```
--- PASS: TestAccAWSCloudFormationStackSet_basic (15.29s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (22.90s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (39.15s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (39.37s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (43.84s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (44.60s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (50.43s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (62.88s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (66.14s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (69.07s)
```
@bflad
tests/resource/aws_cloudformation_stack: Ensure resource recreation w…
5a5f03d 
…hen deleted outside Terraform

Output from acceptance testing:

```
--- PASS: TestAccAWSCloudFormationStack_disappears (69.36s)
```
@bflad bflad added new-resource Introduces a new resource. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Mar 20, 2019
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 20, 2019
@bflad
New Resource: aws_cloudformation_stack_set_instance
0c87115 
Output from acceptance testing:

```
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (116.33s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (123.01s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (131.07s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (161.53s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (225.51s)
```
@bflad bflad force-pushed the f-aws_cloudformation_stack_set branch from 088db10 to 0c87115 Compare March 20, 2019 06:37
@bflad bflad requested a review from a team March 20, 2019 13:39
nywilken
nywilken approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written 👍

@bflad bflad added this to the v2.3.0 milestone Mar 21, 2019
@bflad bflad merged commit 02faf8e into master Mar 21, 2019
@bflad bflad deleted the f-aws_cloudformation_stack_set branch March 21, 2019 13:55
bflad added a commit that referenced this pull request Mar 21, 2019
@bflad
Update CHANGELOG for #8020
95eadf0
@bflad
Copy link
Contributor Author

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken