Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy_tags_to_snapshot attribute for aws_rds_cluster resource #8544

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8504

Release note for CHANGELOG:

- resource/aws_rds_cluster: Add `copy_tags_to_snapshot` attribute.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_copyTagsToSnapshot'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSRDSCluster_copyTagsToSnapshot -timeout 120m
=== RUN   TestAccAWSRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccAWSRDSCluster_copyTagsToSnapshot
=== CONT  TestAccAWSRDSCluster_copyTagsToSnapshot
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (232.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	232.474s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSRDSCluster_basic -timeout 120m
=== RUN   TestAccAWSRDSCluster_basic
=== PAUSE TestAccAWSRDSCluster_basic
=== CONT  TestAccAWSRDSCluster_basic
--- PASS: TestAccAWSRDSCluster_basic (139.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	139.890s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 7, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label May 7, 2019
@bflad bflad added this to the v2.10.0 milestone May 7, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509! 🚀

Output from acceptance testing (failures unrelated):

--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (8.23s)
--- PASS: TestAccAWSRDSCluster_generatedName (118.76s)
--- PASS: TestAccAWSRDSCluster_iamAuth (133.74s)
--- PASS: TestAccAWSRDSCluster_basic (135.21s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (135.91s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (130.33s)
--- PASS: TestAccAWSRDSCluster_namePrefix (140.09s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (140.21s)
--- PASS: TestAccAWSRDSCluster_encrypted (153.50s)
--- PASS: TestAccAWSRDSCluster_kmsKey (154.07s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (155.08s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (159.76s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (159.96s)
--- PASS: TestAccAWSRDSCluster_updateCloudwatchLogsExports (160.26s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (160.13s)
--- PASS: TestAccAWSRDSCluster_importBasic (163.44s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (194.51s)
--- PASS: TestAccAWSRDSCluster_updateTags (198.33s)
--- FAIL: TestAccAWSRDSCluster_EngineMode (244.24s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (117.49s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier (123.87s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (140.30s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (125.12s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (132.93s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (237.46s)
--- PASS: TestAccAWSRDSCluster_Port (264.56s)
--- FAIL: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (302.40s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (325.88s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (326.02s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (305.00s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (355.23s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (366.29s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (386.41s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (391.52s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (356.47s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (348.51s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (335.61s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (358.16s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1122.78s)
--- FAIL: TestAccAWSRDSCluster_s3Restore (1462.12s)
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (2975.03s)

@bflad bflad merged commit c922afb into hashicorp:master May 7, 2019
bflad added a commit that referenced this pull request May 7, 2019
@bflad
Copy link
Contributor

bflad commented May 10, 2019

This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-copy_tags_to_snapshot-attribute-support-for-aws_rds_cluster-resource branch March 5, 2020 14:01
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform support to add RDS CLUSTER attribute for copy_tags_to_snapshot
2 participants