New Resource: aws_athena_workgroup #9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase Master
Signed-off-by: Marco Tesch <[email protected]>
Added skeleton of resourceAwsAthenaWorkgroupUpdate Function Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Added Update Functionality for the Parameter Signed-off-by: Marco Tesch <[email protected]>
Added Updated Test for WorkGroup w. BSCPQ Param. Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Added ARN creation Fixed Pointer Dereferencing Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
Signed-off-by: Marco Tesch <[email protected]>
…m/marcotesch/terraform-provider-aws into f-aws_athena_workgroup
…https:/kterada0509/terraform-provider-aws into f-aws_athena_workgroup
…naming and resourceName Output from acceptance testing: ``` --- PASS: TestAccAWSAthenaWorkGroup_basic (14.00s) --- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (14.37s) --- PASS: TestAccAWSAthenaWorkGroup_Description (17.85s) --- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (19.08s) --- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (19.61s) --- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (21.42s) --- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (49.26s) --- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (55.55s) PASS ```
Reference: #7667 Output from acceptance testing: ``` --- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (15.52s) --- PASS: TestAccAWSAthenaWorkGroup_basic (17.55s) --- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (20.21s) --- PASS: TestAccAWSAthenaWorkGroup_Description (20.46s) --- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (22.00s) --- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (26.63s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (32.47s) --- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (54.68s) --- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (60.36s) ```
…re error message contains "is not found" for triggering recreation Output from acceptance testing: ``` --- PASS: TestAccAWSAthenaWorkGroup_disappears (9.80s) --- PASS: TestAccAWSAthenaWorkGroup_basic (13.86s) --- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (16.05s) --- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (20.70s) --- PASS: TestAccAWSAthenaWorkGroup_Description (22.30s) --- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (24.07s) --- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (26.29s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (34.70s) --- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (54.73s) --- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (60.03s) PASS ```
….Set() Output from acceptance testing: ``` --- PASS: TestAccAWSAthenaWorkGroup_basic (13.65s) --- PASS: TestAccAWSAthenaWorkGroup_disappears (22.50s) --- PASS: TestAccAWSAthenaWorkGroup_Description (22.89s) --- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (24.08s) --- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (24.58s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (28.98s) --- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (30.44s) --- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (36.83s) --- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (56.71s) --- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (58.03s) PASS ```
Output from acceptance testing: ``` --- PASS: TestAccAWSAthenaWorkGroup_disappears (8.22s) --- PASS: TestAccAWSAthenaWorkGroup_basic (17.59s) --- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (22.79s) --- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (24.16s) --- PASS: TestAccAWSAthenaWorkGroup_Description (24.87s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (31.45s) --- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (31.49s) --- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (36.48s) --- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (52.29s) --- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (52.68s) PASS ```
Output from acceptance testing: ``` --- PASS: TestAccAWSAthenaWorkGroup_disappears (9.19s) --- PASS: TestAccAWSAthenaWorkGroup_basic (15.71s) --- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (16.68s) --- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (21.81s) --- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (29.38s) --- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (30.03s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (35.51s) --- PASS: TestAccAWSAthenaWorkGroup_State (36.61s) --- PASS: TestAccAWSAthenaWorkGroup_Description (38.45s) --- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (53.81s) --- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (55.70s) PASS ```
…d attribute validation, and some finishing touches Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSAthenaWorkGroup_disappears (9.08s) --- PASS: TestAccAWSAthenaWorkGroup_basic (15.76s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3 (25.96s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration (27.10s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (31.92s) --- PASS: TestAccAWSAthenaWorkGroup_State (36.06s) --- PASS: TestAccAWSAthenaWorkGroup_Description (36.53s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery (37.99s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled (41.14s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation (54.00s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms (57.21s) PASS ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSAthenaWorkGroup_disappears (13.12s) --- PASS: TestAccAWSAthenaWorkGroup_basic (19.15s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3 (21.32s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled (28.45s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration (33.33s) --- PASS: TestAccAWSAthenaWorkGroup_Description (33.73s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery (36.62s) --- PASS: TestAccAWSAthenaWorkGroup_Tags (39.83s) --- PASS: TestAccAWSAthenaWorkGroup_State (45.99s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms (63.29s) --- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation (64.17s) PASS ```
bflad
added
new-resource
ghost
added
size/XXL
This was referenced Jul 10, 2019
nywilken
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
LGTM 👍 👍
--- PASS: TestAccAWSAthenaWorkGroup_disappears (13.89s)
--- PASS: TestAccAWSAthenaWorkGroup_basic (19.77s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_SseS3 (19.79s)
--- PASS: TestAccAWSAthenaWorkGroup_Description (30.99s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_PublishCloudWatchMetricsEnabled (31.02s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_BytesScannedCutoffPerQuery (32.87s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_EnforceWorkgroupConfiguration (32.89s)
--- PASS: TestAccAWSAthenaWorkGroup_State (43.48s)
--- PASS: TestAccAWSAthenaWorkGroup_Tags (47.17s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_OutputLocation (68.11s)
--- PASS: TestAccAWSAthenaWorkGroup_Configuration_ResultConfiguration_EncryptionConfiguration_Kms (97.14s)
|
This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Includes and supersedes #7995
Includes and supersedes #8136
Closes #7650
Closes #7667
Release note for CHANGELOG:
Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):