-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for dynamodb autoscaling policy import #8397
Merged
nywilken
merged 8 commits into
hashicorp:master
from
jdecarli:fix-for-dynamodb-policy-import-issue-8306
Jul 18, 2019
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6f4e59b
fix to fix dynamodb autoscaling policy import and also keep ecs and r…
jdecarli 8e280ed
refactor/cleanup and unit test for validateAppautoscalingPolicyImport…
jdecarli ca98ae3
updating to use the same table names as the documentation
jdecarli c4f2e1e
refactor and cleanup resourceAwsAppautoscalingPolicyImport
jdecarli b0e095c
fixing typo/error in test logic
jdecarli 7d86d43
fixing integration test (TestAccAWSAppautoScalingPolicy_dynamoDb)
jdecarli 7ecc6c1
resource/aws_appautoscaling_policy: Update import validation support
nywilken a04400e
Merge branch 'master' into fix-for-dynamodb-policy-import-issue-8306
nywilken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about moving all this string splitting logic into
validateAppautoscalingPolicyImportInput
to help simplify the Import function?