Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to react native ^0.71.0 #544

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

DavidBertet
Copy link
Contributor

@DavidBertet DavidBertet commented Jun 2, 2023

Summary

The example project is outdated.

Take the opportunity to update the example project to latest React / ReactNative version / app template

These 3 tickets are kinda related, and could be closed - at least the last 2

Done

  • Update to React ^18.2.0 and React Native ^0.71.0
  • Use latest app templates and tune them to import the native module
  • Didn't put back uses-permission in Manifest as they are added automatically by Gradle while merging the dependency with the app.

How did you test this change?

Run following commands on a fresh clone

yarn bootstrap
yarn example android
yarn example ios

Compiles flawlessly on latest Xcode 14.3.1 / Android.

Tried all cases on device for both platforms. Works the same as before

There is one difference to note on Android, which now asks for camera permission. When allowed, the first time the camera doesn't reload and screen is black. There is an issue for that #528, this PR offers an easy way to reproduce it with the example project

@DavidBertet
Copy link
Contributor Author

@scarlac let me know if I can help speed up the review

@scarlac scarlac merged commit c952ab7 into teslamotors:master Jun 12, 2023
This was referenced Jun 12, 2023
@DavidBertet DavidBertet deleted the task/update_example branch June 28, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants