Update Docker dependency to Docker 20.10.3. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we omit the platform, as this defaults to the host platform arch and is only relevant for systems multi-arch supporting systems.
|
Thanks a lot for that @michielboekhoff ! I agree with you we do not need to expose that parameter for now! |
|
Thanks @michielboekhoff ! @gianarb is it possible to get a new release with this fix? |
This was referenced Mar 12, 2021
Merged
This was referenced Mar 15, 2021
Closed
Closed
StevenMaude
added a commit
to sensiblecodeio/hanoverd
that referenced
this pull request
Jul 12, 2021
The `nil` parameter refers to the software platform: if `nil`, then this defaults to the host platform. It seems reasonable to leave this as is for now. Ref: testcontainers/testcontainers-go#283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #273, as this changes the version of the Docker dependency to 20.10.3.
The backward-incompatible parameter in the call to
ContainerCreateis the platform, which is for images with different platforms (e.g.linux/amd64vslinux/arm64). If not specified, this ends up defaulting to the host platform from what I understand, and is only relevant for machines that are multi-platform capable. At any rate, this is an option we can expose as part of this PR, but I think the use-case is so niche, it might not be worth the effort, as testing that might prove difficult.