Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sonarcloud): run only when docker is not rootless #1608

Merged
merged 1 commit into from
Sep 12, 2023
Merged

ci(sonarcloud): run only when docker is not rootless #1608

merged 1 commit into from
Sep 12, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Sep 11, 2023

What does this PR do?

  • run sonarcloud only when docker is not rootless
  • generate a checkstyle report from golangci-lint for sonarcloud, see documentation
  • correct path of test report as it was not correctly discovered

@mmorel-35 mmorel-35 requested a review from a team as a code owner September 11, 2023 20:26
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d7f1ea0
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64ff8335e14aa50008779318
😎 Deploy Preview https://deploy-preview-1608--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Sep 12, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Sep 12, 2023
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit b1b4a07 into testcontainers:main Sep 12, 2023
99 checks passed
@mmorel-35 mmorel-35 deleted the patch-1 branch September 12, 2023 06:38
mdelapenya added a commit that referenced this pull request Sep 12, 2023
…containerd-1.7.5

* main:
  chore: always generate the examples including a explicit image (#1611)
  chore: support linting all modules locally (#1609)
  ci(sonarcloud): run only when not root-less (#1608)
  remove extra equal in sonar.organization (#1607)
  chore(ci): enable code coverage on Sonarcloud (#1518)
  docs: use Go testable examples in modules (#1603)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 12, 2023
* main:
  chore: always generate the examples including a explicit image (testcontainers#1611)
  chore: support linting all modules locally (testcontainers#1609)
  ci(sonarcloud): run only when not root-less (testcontainers#1608)
  remove extra equal in sonar.organization (testcontainers#1607)
  chore(ci): enable code coverage on Sonarcloud (testcontainers#1518)
  docs: use Go testable examples in modules (testcontainers#1603)
  ci(lint): enable errorlint linter (testcontainers#1604)
  ci(lint): enable gocritic linter (testcontainers#1605)
  chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (testcontainers#1566)
  ci(security): setup codeql scan  (testcontainers#1606)
  chore(deps): bump github.com/cyphar/filepath-securejoin (testcontainers#1601)
  chore: generate Go examples for new modules (testcontainers#1600)
  chore: generate Go examples for new modules (testcontainers#1600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants