feat: add functional option for startup commands #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
feature
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 20, 2023
* main: docs: have common options in a common markdown file (testcontainers#1648) feat: add functional option for startup commands (testcontainers#1647) fix: support running the semver Docker image interactively (testcontainers#1646) fix: proper next version chore: prepare for next minor development cycle () chore: use new version (v0.24.1) in modules and examples fix: avoid deadlocks when Docker is not available (testcontainers#1645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a functional option to run arbitrary commands in the container that uses them.
The startup commands will be treated as an slice of strings that will be executed in the container right after it's started. For that, it will leverage the lifecycle hooks of the container, more specifically the
PostStartshooks. A new lifecycle hook will be created, which will be appended to the existing lifecycle hooks.Finally, the new functional option has been documented in all existing modules, including the template for new ones.
Why is it important?
Containers, and more importantly modules, many time needs to run commands right after they are started to define a desired state. With this approach, we will simplify the way they users add those startup commands when defining a request for a container or a module.