Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve experience for creating modules for first time #1690

Merged

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Sep 26, 2023

What does this PR do?

In the modules page, it gives more importance to the code snippet for running the CLI tool to create a new module.

It also updates the template that generates the code for examples, removing the need for generating the examples_test.go file for example modules.

Why is it important?

Before these changes, the first code snippet was for creating a code example, which was misleading causing confusion on how to run the tool.

Fix the bug in the template is also important.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner September 26, 2023 11:27
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d8172e1
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6512c0209b758700075c7e3a
😎 Deploy Preview https://deploy-preview-1690--testcontainers-go.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Sep 26, 2023
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Sep 26, 2023
@mdelapenya mdelapenya merged commit 51cde33 into testcontainers:main Sep 26, 2023
106 checks passed
@mdelapenya mdelapenya deleted the fix-docs-experience-for-modules branch September 26, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant