Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip TestContainerLogWithErrClosed as flaky on rootless docker #1925

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

mdelapenya
Copy link
Member

What does this PR do?

It skips the TestContainerLogWithErrClosed tests on Rootless docker environments, as it is flaky under those conditions.

Why is it important?

Keep the build stable

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner November 24, 2023 07:03
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Nov 24, 2023
@mdelapenya mdelapenya self-assigned this Nov 24, 2023
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 51c5eb7
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65604ac5fc0b2d000880c0a5
😎 Deploy Preview https://deploy-preview-1925--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit 480cadd into testcontainers:main Nov 24, 2023
112 checks passed
@mdelapenya mdelapenya deleted the skip-flaky-test branch November 24, 2023 09:43
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Nov 30, 2023
* main: (100 commits)
  fix: fallback matching of registry authentication config (testcontainers#1927)
  feat: support customizing the Docker build command (testcontainers#1931)
  docs: include MongoDB's username and password options into the docs (testcontainers#1930)
  feat: support for custom registry prefixes at the configuration level (testcontainers#1928)
  Add username and password functions to mongodb (testcontainers#1910)
  chore: skip TestContainerLogWithErrClosed as flaky on rootless docker (testcontainers#1925)
  docs: add some Vault module examples (testcontainers#1825)
  feat: support for executing commands in a container with user, workDir and env (testcontainers#1914)
  fix(modules.kafka): Switch to MaxInt for 32-bit support (testcontainers#1923)
  docs: fix code snippet for image substitution (testcontainers#1918)
  Add database driver note to SQL Wait strategy docs (testcontainers#1916)
  Reduce flakiness in ClickHouse tests (testcontainers#1902)
  lint: enable nonamedreturns (testcontainers#1909)
  chore: deprecate BindMount APIs (testcontainers#1907)
  fix(reaper): fix race condition when reusing reapers (testcontainers#1904)
  feat: Allow the container working directory to be specified (testcontainers#1899)
  chore: make rabbitmq examples more readable (testcontainers#1905)
  chore(deps): bump github.com/twmb/franz-go and github.com/twmb/franz-go/pkg/kadm in /modules/redpanda (testcontainers#1896)
  Fix - respect ContainerCustomizer in neo4j module (testcontainers#1903)
  chore(deps): bump github.com/nats-io/nkeys and github.com/nats-io/nats.go in /modules/nats (testcontainers#1897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant