Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds gotestsum to install tools #2043

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Dec 22, 2023

What does this PR do?

Adds installation for gotestsum as required by make target

Why is it important?

Minor change to help new contributors contribute

  1. checkout this PR
  2. set your GOPATH envvar to a new directory
  3. run make test-all or make test-tools

@hughesjj hughesjj requested a review from a team as a code owner December 22, 2023 01:09
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit faf6e06
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6584e1e362e34d0008f613ca
😎 Deploy Preview https://deploy-preview-2043--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this tiny refinement to the "build", but valuable for contributions, as you said

I recall having this in the past, probably removed when we delegated the usage of gotestsum to the CI, but some leftovers were missing. Thanks in any case for taking care of the dev experience 👏

LGTM

@mdelapenya mdelapenya self-assigned this Dec 22, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Dec 22, 2023
@mdelapenya mdelapenya merged commit 61a37cb into testcontainers:main Dec 22, 2023
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants