Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding inbucket module #2142

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Adding inbucket module #2142

merged 7 commits into from
Jan 26, 2024

Conversation

jespino
Copy link
Contributor

@jespino jespino commented Jan 24, 2024

What does this PR do?

This PR adds the inbucket module

Why is it important?

An important part of testing application usually involves sending emails,
inbucket helps a lot in this task acting like an MTA that you can inspect later
to do assertions.

How to test this PR

I included unit tests that verifies the correct behavior

@jespino jespino requested a review from a team as a code owner January 24, 2024 18:01
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a72c93e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65b38d910e988500084b5a0a
😎 Deploy Preview https://deploy-preview-2142--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, not blockers, regarding names.

Other than that, LGTM, thanks!

modules/inbucket/inbucket.go Outdated Show resolved Hide resolved
modules/inbucket/inbucket.go Show resolved Hide resolved
modules/inbucket/inbucket_test.go Outdated Show resolved Hide resolved
@mdelapenya mdelapenya self-assigned this Jan 26, 2024
@mdelapenya mdelapenya added the enhancement New feature or request label Jan 26, 2024
mdelapenya
mdelapenya previously approved these changes Jan 26, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for your hard work contributing modules!

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job again! Thanks for this new module, I'm pretty sure the community will thank having a way to test email interactions! 👏👏👏

LGTM!

@mdelapenya mdelapenya merged commit 35d28e3 into testcontainers:main Jan 26, 2024
128 checks passed
mdelapenya added a commit to laskoviymishka/testcontainers-go that referenced this pull request Jan 26, 2024
* main:
  Adding inbucket module (testcontainers#2142)
  testifylint: enable compares rule (testcontainers#2143)
  Bump containerd version to v1.7.12 (testcontainers#2137)
  feat: Add Minio module (testcontainers#2132)
  Adding LogConsumers start as part of the ContainerRequest (testcontainers#2073)
  chore: bring back assertion for network aliases for bridge in rootless mode (testcontainers#2141)
  chore(deps): bump github.com/docker/compose/v2 from 2.23.3 to 2.24.0 in /modules/compose (testcontainers#2096)
mdelapenya added a commit to tateexon/testcontainers-go that referenced this pull request Jan 29, 2024
* main: (74 commits)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162)
  feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131)
  chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161)
  chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165)
  chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169)
  chore(deps): bump google.golang.org/api from 0.156.0 to 0.159.0, google.golang.org/grpc from 1.60.1 to 1.61.0, cloud.google.com/go/pubsub from 1.33.0 to 1.35.0 in /modules/gcloud (testcontainers#2168)
  chore(deps): bump github.com/hashicorp/consul/api in /examples/consul (testcontainers#2152)
  chore(deps): bump github.com/couchbase/gocb/v2 in /modules/couchbase (testcontainers#2145)
  chore(deps): bump k8s.io/api, k8s.io/apimachinery and k8s.io/client-go from 0.29.0 to 0.29.1 in /modules/k3s (testcontainers#2167)
  chore: do not compile modules on macos workers on GH (testcontainers#2164)
  Openldap module support (testcontainers#2117)
  Adding inbucket module (testcontainers#2142)
  testifylint: enable compares rule (testcontainers#2143)
  Bump containerd version to v1.7.12 (testcontainers#2137)
  feat: Add Minio module (testcontainers#2132)
  Adding LogConsumers start as part of the ContainerRequest (testcontainers#2073)
  chore: bring back assertion for network aliases for bridge in rootless mode (testcontainers#2141)
  chore(deps): bump github.com/docker/compose/v2 from 2.23.3 to 2.24.0 in /modules/compose (testcontainers#2096)
  chore(deps): bump github.com/dvsekhvalnov/jose2go in /modules/pulsar (testcontainers#2136)
  fix: skip-host-cache option removed in latest MySQL 8.3.0 version (testcontainers#2130)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants