Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce test package in modules #2241

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

mdelapenya
Copy link
Member

  • fix: include import of the log package
  • chore: use test package in new modules
  • chore: use test package in modules
  • chore: improve mssql test

What does this PR do?

This PR uses the _test package in all the modules that were not using it.

When needed, we have created a separate test file living in the same package's context in order not to leak helper functions to the public API of the module.

Why is it important?

Consistency across the project, following a best practice

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner February 16, 2024 16:02
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Feb 16, 2024
@mdelapenya mdelapenya self-assigned this Feb 16, 2024
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit b3b867a
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65cf91ceb22d5e00088f0c33
😎 Deploy Preview https://deploy-preview-2241--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit a3f02ab into testcontainers:main Feb 16, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant