Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testcontainers labels to the built images #2579

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Jun 12, 2024

What does this PR do?

This PR adds the default labels to the images that are built from a Dockerfile.

Why is it important?

It will add the images to Ryuk death notes.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner June 12, 2024 11:55
@mdelapenya mdelapenya self-assigned this Jun 12, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 12, 2024
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 4d32b7d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6669909e9ec0050008e648ce
😎 Deploy Preview https://deploy-preview-2579--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

mdelapenya commented Jun 14, 2024

I've been internally checking with the Docker team responsible for building images, and they confirm that this fix will not apply to all the interstitial images. They also share the implications for doing that are not trivial, and would need more work from the build site.

Even though this is not the right fix for all the interstitial images, merging this is convenient for the images built by Testcontainers, that's why I'm going to merge this one.

I'm also changing the type of the issue, from chore to feature, as it will add a new behaviour, which is removing the built images (is it a feature is it a bug? 😅)

@mdelapenya mdelapenya added feature New functionality or new behaviors on the existing one and removed chore Changes that do not impact the existing functionality labels Jun 14, 2024
@mdelapenya mdelapenya changed the title chore: add testcontainers labels to the built images feat: add testcontainers labels to the built images Jun 14, 2024
@mdelapenya mdelapenya merged commit 2681ae4 into testcontainers:main Jun 14, 2024
106 checks passed
@mdelapenya mdelapenya deleted the build-images-with-labels branch June 14, 2024 18:14
mdelapenya added a commit that referenced this pull request Jun 14, 2024
* chore: add testcontainers labels to the built images

* fix: update test
mdelapenya added a commit that referenced this pull request Jun 18, 2024
* chore: add testcontainers labels to the built images

* fix: update test
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 24, 2024
* main:
  docs: document disabling ryuk with properties (testcontainers#2603)
  fix: allow compose files and readers to be used together (testcontainers#2598)
  chore(deps): bump urllib3 from 2.2.1 to 2.2.2 (testcontainers#2590)
  docs: example for NATS cluster (testcontainers#2591)
  docs: fix deprecation for material extensions emoji (testcontainers#2592)
  gha: update golangci-lint to v1.59.1 (testcontainers#2588)
  network: WithCheckDuplicate: don't set CheckDuplicate value (testcontainers#2589)
  fix: proper synchronisation for start/stop log production (testcontainers#2576)
  chore(deps): bump github.com/docker/docker from v25.0.5 to v26.1.4 (testcontainers#2584)
  docs: update contributing guide (testcontainers#2586)
  feat: add testcontainers labels to the built images (testcontainers#2579)
  feat(mongodb): Make the replica set name configurable (testcontainers#2538)
  chore: skip reaper tests if ryuk is disabled (testcontainers#2582)
  chore: increase check time to 60 secs instead of 20 (testcontainers#2581)
  fix: prepend substitutors for built images (testcontainers#2577)
  docs: update colima docs (testcontainers#2578)
  fix(cockroachdb): Fixes cockroachdb wait strategy handling (testcontainers#2456)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant