chore(tests): rename test variables to kill sshd container more consistently #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit 3981e9b.
This reverts commit 1af71c4.
* main: docs: document disabling ryuk with properties (testcontainers#2603) fix: allow compose files and readers to be used together (testcontainers#2598) chore(deps): bump urllib3 from 2.2.1 to 2.2.2 (testcontainers#2590) docs: example for NATS cluster (testcontainers#2591)
mdelapenya
changed the title
mdelapenya
added a commit
that referenced
this pull request
Jun 24, 2024
* main: chore(tests): rename test variables to kill sshd container more consistently (#2597)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jun 24, 2024
* main: chore(tests): rename test variables to kill sshd container more consistently (testcontainers#2597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It updates the variable names used in the tests so that it's easier to read and understand what testing instance will be used.
Why is it important?
There is some flakiness in the reaper-off tests, so we are trying to address it.
Follow-ups
Remove last commit, as it's used to run this PR very frequently (hourly) and check if the fix is consistent the soonest.