Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add retry on system error test #2687

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Aug 6, 2024

Add a test to cover the retry on system error test.

Update test to use empty context to prevent knock on failures being logged confusing the output and check the error returned.

Add a test to cover the retry on system error test.

Update test to use empty context to prevent knock on failures being
logged confusing the output and check the error returned.
@stevenh stevenh requested a review from a team as a code owner August 6, 2024 20:16
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 8447275
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b284b09013460008f1f0d9
😎 Deploy Preview https://deploy-preview-2687--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Aug 8, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 8, 2024
@mdelapenya mdelapenya merged commit e4ce806 into testcontainers:main Aug 8, 2024
112 checks passed
mdelapenya added a commit that referenced this pull request Aug 9, 2024
* main:
  fix(compose): remove test volumes (#2712)
  chore(mysql): add missing error check in example (#2707)
  chore: remove unused params from defaultPreCreateHook (#2714)
  docs: improve docs for container methods (#2713)
  chore(registry): disable build log (#2711)
  chore: remove obsolete compose version (#2710)
  chore: improve lifecycle errors (#2708)
  docs: add consistent snippets for network creation (#2703)
  test: add retry on system error test (#2687)
  Redpanda Module: Add option for arbitrary bootstrap config (#2666)
  feat(inbucket): expose POP3 and wait for all ports (#2690)
  fix(wait): data race in test (#2698)
  fix(milvus): racy container setup (#2693)
  fix(mongodb): replica test failures (#2699)
  test: racy port creation in port forwarding tests (#2688)
  fix: port forwarding race condition (#2686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants