-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container information stauff #271
Conversation
Hi @01101101M, could you share here or in a new issue the motivation for this change? We'd like to better understand the use cases and the real needs to add it. Thanks in advance! |
Hey @mdelapenya, first of all, thank you for your time. Why it's important:
|
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 63.63% 61.30% -2.34%
==========================================
Files 13 15 +2
Lines 924 920 -4
==========================================
- Hits 588 564 -24
- Misses 247 269 +22
+ Partials 89 87 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@01101101M sorry for the delay with the review. I added a tiny rename in a method.
Could you verify that all wait implementation provide the new State
method?
Great! That would be nice. |
@mdelapenya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
some small features added: