Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra hosts to the container request #436

Merged
merged 1 commit into from
May 5, 2022

Conversation

EndPositive
Copy link
Contributor

The code-way of specifying --add-hosts on the Docker command-line.

E.g.

var extraHosts = []string{
    "subdomain.localhost:127.0.0.1",
}

Useful in test scenario's where dynamic domain names are used.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #436 (1193b9e) into main (cd84bb3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   65.13%   65.16%   +0.02%     
==========================================
  Files          19       19              
  Lines        1179     1180       +1     
==========================================
+ Hits          768      769       +1     
  Misses        304      304              
  Partials      107      107              
Impacted Files Coverage Δ
container.go 87.23% <ø> (ø)
docker.go 65.32% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd84bb3...1193b9e. Read the comment docs.

@gianarb gianarb added the feature New functionality or new behaviors on the existing one label May 5, 2022
@mdelapenya mdelapenya merged commit 1f42bf6 into testcontainers:main May 5, 2022
@EndPositive EndPositive deleted the extra_hosts branch May 5, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants