-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: custom ForSQL query #451
feature: custom ForSQL query #451
Conversation
This LGTM, thanks for taking the time to contribute it! I'd miss a test demonstrating the change, but other than that, great job! |
- Test failure message fixed.
Tests added. |
So what to do with failed checks? |
We have certain flakiness #411, but had no bandwidth to work on it yet. In any case, I re-ran your builds 🤞 |
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 68.44% 68.93% +0.48%
==========================================
Files 21 21
Lines 1892 1896 +4
==========================================
+ Hits 1295 1307 +12
+ Misses 480 472 -8
Partials 117 117
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is about adding a dependency on Postgres, which is needed to tun the tests, but will be added to the project dependency on each client code running their tests with tc-go.
I understand the purpose of adding it, although I'd like to avoid adding that dependency. Do you foresee any solution for that?
I can move After that gitlab CI file must be updated... |
I think in this case it is fine, there is a separate module and this is not a new feature but an enhancement for something we already support. |
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
WithQuery
Closes #350