-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use exposed ports specified in image if it is not specified in ContainerRequest #468
Conversation
I will be very grateful if you check my PR ASAP. I can not continue to work on the PR after Jul 13. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two small nits. The PR looks good to me. My only concern is about the call to the wait.ForListeningPort("")
method with an empty string. Not sure if adding a new method, something like wait.ForExposedPort()
would me it more usable though, but I'd like to hear your thoughts on it.
It's not a blocker for this PR, which I will approve once we discuss about it and find ourselves in a closed path.
Co-authored-by: Manuel de la Peña <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
We have Yes, we can add method |
I want it to be simple to use. I we have to do the mental effort of passing an empty string to wait for a port declared at the Dockerfile, then I think it would make it difficult to remember/easy to forget about it, unless the docs/tests are crystal clear. I think we are missing it in the docs, as you already added the example in the tests 👍 If you find it having the alias confusing, then it's OK to keep the method with the empty string, but well documented. |
Codecov Report
@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 65.55% 69.65% +4.10%
==========================================
Files 19 21 +2
Lines 1199 2040 +841
==========================================
+ Hits 786 1421 +635
- Misses 305 495 +190
- Partials 108 124 +16
Continue to review full report at Codecov.
|
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minute changes in docs, but other than that LGTM! Thanks @fiftin for your hard work here
Co-authored-by: Manuel de la Peña <[email protected]>
Thanks for your patience @fiftin!! It's merged now 🚀 |
Relates to #343
Example:
Old:
New: