refactor: read RYUK_CONTAINER_PRIVILEGED once #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
reviewed
Jul 1, 2022
zregvart
force-pushed
the
pr/refactor-privileged-ryuk-env-variable
branch
from
cf12297
to
625af9d
Compare
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 69.56% 69.28% -0.29%
==========================================
Files 21 21
Lines 1942 1947 +5
==========================================
- Hits 1351 1349 -2
- Misses 474 479 +5
- Partials 117 119 +2
Continue to review full report at Codecov.
|
mdelapenya
reviewed
Jul 1, 2022
zregvart
force-pushed
the
pr/refactor-privileged-ryuk-env-variable
branch
3 times, most recently
from
0d545f4
to
2f6a263
Compare
Now the environment variable `TESTCONTAINERS_RYUK_CONTAINER_PRIVILEGED` is read only once in the `configureTC` function that reads the `.testcontainers.properties` file and accesses the environment variable.
zregvart
force-pushed
the
pr/refactor-privileged-ryuk-env-variable
branch
from
2f6a263
to
d28f363
Compare
mdelapenya
reviewed
Jul 5, 2022
| @@ -752,6 +754,11 @@ func readTCPropsFile() TestContainersConfig { | |||
| return TestContainersConfig{} | |||
There was a problem hiding this comment.
I'm going to merge this one, although I wonder if the struct we are returning here should consider the env variables too 🤔
mdelapenya
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the environment variable
TESTCONTAINERS_RYUK_CONTAINER_PRIVILEGEDis read only once in theconfigureTCfunction that reads the.testcontainers.propertiesfile and accesses the environment variable.