Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs regarding Podman usage #503

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

prskr
Copy link
Contributor

@prskr prskr commented Aug 24, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #503 (2dfebf3) into main (94423c4) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   69.77%   69.92%   +0.14%     
==========================================
  Files          21       21              
  Lines        2048     2048              
==========================================
+ Hits         1429     1432       +3     
+ Misses        495      494       -1     
+ Partials      124      122       -2     
Impacted Files Coverage Δ
docker.go 71.65% <0.00%> (+0.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS!!

Thanks for contributing to the docs, which is super important.

I'm taking a note to myself for starting a design discussion on seeing the provider at the properties level: #504

Other than that, great job, as always

@prskr
Copy link
Contributor Author

prskr commented Aug 24, 2022

Thanks a lot! I'll try to add some more docs in the upcoming weeks as I just noticed there's also nothing about container mounts and I think this would make sense as well 😊

@mdelapenya mdelapenya merged commit 31954fc into testcontainers:main Aug 24, 2022
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Aug 25, 2022
@mdelapenya mdelapenya added the podman Issues regarding podman. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs. podman Issues regarding podman.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants