Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify reuse property setting #8872

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Clarify reuse property setting #8872

merged 1 commit into from
Jul 11, 2024

Conversation

MV-GH
Copy link
Contributor

@MV-GH MV-GH commented Jul 10, 2024

With #3411 some documentation became outdated

This clears that up.

Also would be great if someone chimes in here #8060 , from the tests this seems on purpose and not a bug.

@MV-GH MV-GH requested a review from a team as a code owner July 10, 2024 19:45
@kiview kiview added this to the next milestone Jul 11, 2024
kiview
kiview approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @MV-G, this clarification is correct, and I closed #8060 accordingly.

@kiview kiview merged commit 5fbffbd into testcontainers:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
type/docs
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MV-GH @kiview