#1 only import the cssParse function we need #8
Conversation
…sted by css library project member
|
Oh dear. Looks like a caching problem in your build script? :( |
src/toHaveStyle.js
Outdated
| import { checkHtmlElement, getTag, InvalidCSSError } from './utils'; | ||
| import { printSecSuccess, printSuccess, printSecError, printError } from './printers'; | ||
| import cssParse from 'css/lib/parse'; |
There was a problem hiding this comment.
I guess that should be on the first line in this file, since it is module import, then own dependencies goes
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 21 21
Lines 596 596
=======================================
Hits 593 593
Misses 3 3
Continue to review full report at Codecov.
|
I'll try this out on the weekend @IanGrainger! Let's hope for the best. Thank you for your support and your efforts. |
…er/jasmine-dom into cssparse-import-change
|
I've pushed changing the import order. Sorry about that! 😅 Hey, how'd the new job go? Did you get it?? 😄 |
|
I did get a new job, thanks for asking! 😄 Thank you for putting so much work into this. |
|
@all-contributors add @IanGrainger for code |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I've put up a pull request to add @IanGrainger! 🎉 |
What:
We can't import the CSS library in the browser (which is how Karma runs the tests) - because of an error
Module not found: Error: Can't resolve 'fs'. But as suggested by a developer on that project, we can just import the function we need from the library.Why:
Because attempting to run tests with Karma results in an error:
Module not found: Error: Can't resolve 'fs'.How:
Import the cssParse function we need rather than the whole css library.
Checklist: