feat(ci/license-check): check if specifed images have been manually l… #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinWolff
requested review from
tasches and
cwrau
and removed request for
SyeKlu
marvinWolff
force-pushed
the
feat/ci/check_license_list
branch
from
60ae79d
to
ee1cdff
Compare
marvinWolff
commented
Oct 9, 2024
marvinWolff
force-pushed
the
feat/ci/check_license_list
branch
from
ee1cdff
to
0909974
Compare
marvinWolff
force-pushed
the
feat/ci/check_license_list
branch
from
0909974
to
5300f56
Compare
cwrau
requested changes
Oct 14, 2024
| - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 | ||
| - run: pip install yq | ||
| - run: | | ||
| mapfile -t IMAGES < <(for chart in charts/*; do if [[ -f "$chart/Chart.yaml" ]]; then yq -r '.annotations["artifacthub.io/images"] // ""' <"$chart/Chart.yaml" ; fi; done | cut -d ":" -f2 | uniq | sort | sed '/^$/d') |
There was a problem hiding this comment.
This should rather just use the $chart from getChangedChart
There was a problem hiding this comment.
I hope this is fine now, testing is hard when using github-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…icense checked
Also fixed title of job.
This will fix the problem with trivy, that the licenses of the software in an docker-image are ok, and not if the docker-image itself is ok.
The list will contain every image used by us and check, if an image used by us is not in this list.