fix(t8s-cluster/clusterClass): fix redundant rolling of machines #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
ghost
reviewed
Jun 14, 2023
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-storageclasses.yaml
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jun 14, 2023
charts/t8s-cluster/templates/management-cluster/clusterClass/clusterClass.yaml
Show resolved
Hide resolved
|
Being able to configure the image name template is a very nice bonus! |
Changing the openStackMachineTemplates resulted in a rolling of the machines in the old version and then again in the new version. As now the openStackMachineTemplates are not touched this doesn't happen anymore.
cwrau
force-pushed
the
fix/t8s-cluster-redundant-rolling-of-machines
branch
from
aa94ceb
to
b0faf19
Compare
marvinWolff
approved these changes
Jul 24, 2023
This was referenced Jan 18, 2024
This was referenced Apr 26, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the openStackMachineTemplates resulted in a rolling of the machines in the old version and then again in the new version.
As now the openStackMachineTemplates are not touched this doesn't happen anymore.