Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base-cluster/tracing): add missing otel to trusted image #552

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix(base-cluster/tracing): add missing otel to trusted image #552

merged 1 commit into from
Sep 8, 2023

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Sep 7, 2023

No description provided.

@cwrau cwrau requested review from marvinWolff, tasches and a team as code owners September 7, 2023 09:47
@cwrau cwrau enabled auto-merge (squash) September 7, 2023 09:47
@teutonet-bot
Copy link
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/rbac-values.yaml has no changes

[charts/base-cluster/ci/imagepullsecrets-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> 
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/values.yaml has no changes

charts/base-cluster/ci/artifacthub-values.yaml

charts/base-cluster/ci/flux-gitrepositories-values.yaml has no changes

charts/base-cluster/ci/basic-values.yaml has no changes

charts/base-cluster/ci/velero-backupStorageLocations-values.yaml has no changes

tasches
tasches approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@tasches tasches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwrau cwrau merged commit 5332ca8 into main Sep 8, 2023
10 checks passed
@cwrau cwrau deleted the feat/base-cluster-add-otel-images branch September 8, 2023 13:43
@teutonet-bot teutonet-bot mentioned this pull request Sep 8, 2023
Merged
@teutonet-bot teutonet-bot mentioned this pull request Jan 18, 2024
Merged
This was referenced Feb 12, 2024
Merged
Merged
This was referenced Apr 22, 2024
Merged
Merged
Merged
Merged
@teutonet-bot teutonet-bot mentioned this pull request Jun 21, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Jul 4, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Jul 17, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Jul 31, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasches tasches tasches approved these changes

@marvinWolff marvinWolff Awaiting requested review from marvinWolff marvinWolff is a code owner

Assignees

@cwrau cwrau

Labels
base-cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwrau @teutonet-bot @tasches