Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenated class names in tables cells and rows #164

Closed
ikirudennis opened this issue Feb 2, 2016 · 2 comments
Closed

Hyphenated class names in tables cells and rows #164

ikirudennis opened this issue Feb 2, 2016 · 2 comments

Comments

@ikirudennis
Copy link
Member

I've noticed a slight bug with how attributes are parsed regarding table cells and rows. If the cell or row has a class specified which has a hyphen in it, it also adds vertical-align: middle to the cell's style attribute. (The same goes for caret or tilde in the class name, but those seem less likely to used.) It seems like the vertical-alignment shorthand should only apply when one of those characters is included at the start of the row/cell, otherwise ignored. Correct?

For example, an old test from python-textile:

table(linkblog-thumbnail).
|(linkblog-thumbnail-cell). apple|bear|

Using txstyle.org, it turns into:

<table class="linkblog-thumbnail">
        <tr>
            <td class="linkblog-thumbnail-cell" style="vertical-align:middle;">apple</td>
            <td>bear</td>
        </tr>
</table>

Seems like this could use a caret at the start.

@netcarver
Copy link
Contributor

@ikirudennis Thanks for reporting this Dennis. Now fixed in the issue-164 branch and will be merged into master for the next release.

@netcarver
Copy link
Contributor

Just pushed the fix for this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants