Fix ChoiceField schema type with empty choices=[]
#1240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ChoiceField(choices=[])
will get{"type": "boolean"}
in schema. With this change,type
wil be omitted from schema.Currently
ChoiceField(chocies=[], allow_blank=True)
will generate schema{"type": "boolean", "enum": [""]}
, that's a bit nonsensical, as the only enum listed value""
is string, not boolean. With this change,{"type": "string", "enum": [""]}
will be generated.This PR fixes these edge cases.