Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback speed slider is not displayed #1045

Closed
Resdryn opened this issue Feb 27, 2023 · 8 comments · Fixed by #1048
Closed

Playback speed slider is not displayed #1045

Resdryn opened this issue Feb 27, 2023 · 8 comments · Fixed by #1048

Comments

@Resdryn
Copy link

Resdryn commented Feb 27, 2023

Well recently I wanted to hear a song possibly at 1.25x or more because I couldn't find an accelerated version and I just loved it when I saw it in an edit of a game. I saw the playback speed plugin and thought it would be perfect, but... The slider doesn't appear, I asked a friend to download the app, activate the plugin, restart the app and insert a song, but it didn't appear for him either.
Note: Translated by google translate, with reverse translate
@Araxeus
Copy link
Collaborator

Araxeus commented Feb 28, 2023

image

works for me, are you sure you checked the right place?

@Resdryn
Copy link
Author

Resdryn commented Feb 28, 2023

Yep, i also tried to change my resolution (1440x900 to 1980x1080) but not shown.
image

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 28, 2023

if you enable the downloader or picture-in-picture plugins does it add the buttons like in my screenshot above?

@Resdryn
Copy link
Author

Resdryn commented Feb 28, 2023

Yes, but the speed slider doesnt.
image

Araxeus added a commit to Araxeus/youtube-music that referenced this issue Feb 28, 2023
@Araxeus
fix playback speed selector
edaac9b 
replace querying for the text `Stats` (which is language specific)
with querying that the event origin is the button on the player-bar

fix th-ch#1045
@Araxeus
Copy link
Collaborator

Araxeus commented Feb 28, 2023 •
edited
Loading

I think this might be happening because your YouTube language isn't set to English
(could you try setting it to English, just to confirm my theory?)

Could you compile from a PR/branch — #1048 / https:/Araxeus/youtube-music/tree/fix-playback-speed-selector?
if not, then are you on Windows and want to install the files i built on my pc with the fix?
https://send.vis.ee/download/7bd84a0794d5813a/#Q8sCEXSBwP9Ln4EIBHuJsg

source for dl website https:/timvisee/send / https:/timvisee/send-instances/

Araxeus added a commit to Araxeus/youtube-music that referenced this issue Feb 28, 2023
@Araxeus
fix playback speed selector
79e71da 
replace querying for the text `Stats` (which is language specific)
with querying that the event origin is the button on the player-bar

fix th-ch#1045
@Araxeus Araxeus mentioned this issue Feb 28, 2023
Merged
@Resdryn
Copy link
Author

Resdryn commented Feb 28, 2023

Yes, the problem is the language selected in app. I changed and now the slider appears.
image
About compiling, I'm new and I don't even have a knowledge of programming, so I think it's better if I just install a fixed version, thanks!

@Resdryn
Copy link
Author

Resdryn commented Feb 28, 2023

The bug is fixed in that version:
image

@Resdryn Resdryn closed this as completed Feb 28, 2023
@Araxeus
Copy link
Collaborator

Araxeus commented Feb 28, 2023 •
edited
Loading

You didn't have to close the issue since the linked Pull Request would have automatically closed it when merged

Just FYI 😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix playback speed slider not showing and PiP button showing when it shouldn't Araxeus/youtube-music
2 participants
@Araxeus @Resdryn