Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Thumbnail/Video in fullscreen mode is not covering all screen #2013

Closed
3 of 5 tasks
BryanGIG opened this issue Apr 27, 2024 · 2 comments · Fixed by #2015
Closed
3 of 5 tasks

[Bug]: Thumbnail/Video in fullscreen mode is not covering all screen #2013

BryanGIG opened this issue Apr 27, 2024 · 2 comments · Fixed by #2015

Comments

@BryanGIG
Copy link
Contributor

BryanGIG commented Apr 27, 2024

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

youtube-music-bin 3.3.6-1

Checklists

What operating system are you using?

Other (specify below)

Operating System Version

ArchLinux with Hyprland 0.39.1

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

3.3.2

Reproduction steps

  1. Play music/video
  2. Set fullscreen mode
  3. The video/music thumbnail appears to be fullscreen, the navbar is correct but the thumbnail/video is not
    image

Expected Behavior

The thumbnail/Video should be at the center covering the screen

Actual Behavior

The thumbnail/video seems misplaced

Enabled plugins

  1. Blur Navigation Bar
  2. Navigation
  3. Video Toggle
  4. In-App Menu
  5. Downloader
  6. Discord Rich Presence
  7. Ambient Mode
  8. Ad Blocker

Additional Information

  1. in dev build, this bug appears after DevTools is opened
@BryanGIG
Copy link
Contributor Author

BryanGIG commented Apr 28, 2024

I suspect the bug is from ed700c2 in src/youtube-music.css

ytmusic-player[player-ui-state=FULLSCREEN] {
  top: calc(var(--menu-bar-height, 32px) * -1) !important;
}

where is should be subtract the margin-top instead of top size

@BryanGIG
Copy link
Contributor Author

Yup, it does fix it
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@BryanGIG and others