Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAM rises on v1.19.0 #958

Closed
qtotter opened this issue Jan 10, 2023 · 7 comments · Fixed by #1235
Closed

RAM rises on v1.19.0 #958

qtotter opened this issue Jan 10, 2023 · 7 comments · Fixed by #1235
Labels
fix-available A fix to the issue is available in a new version

Comments

@qtotter
Copy link

qtotter commented Jan 10, 2023

Windows 11 Pro 22H2/Core i5-8350U/RAM 12GB

I tried to download a playlist of 103 songs. The RAM useage before download was 3.7GB (31%), but it gradually rose to around 90% after 7 mins or so as download proceeded, and download just stopped nearly at the end after 101 songs. The download process was still running, and the RAM useage remained around 90% untill I terminated the app. It seems like a typical memory leak situation. Any thoughts?

If I do the same download on Core i5-1035G1/RAM 24GB, its RAM useage went up to 14GB (59%) and stayed there after 101 songs untill I killed the app. It seems it was trying to download or encode the rest two songs, and some process internally hangs up?

Thx!

@Zo-Bro-23
Copy link
Contributor

Does the issue persist with other versions of YTM (1.18, 1.17, etc) and other downloading tools like youtube-dl?

@qtotter
Copy link
Author

qtotter commented Jan 11, 2023

I'm a newbie here, and I haven't tried any older builds. I'll come back to you when I reinstall an oler one or two. Thx!

@qtotter
Copy link
Author

qtotter commented Jan 11, 2023

I tried 1.18, 1.17, but the results were the same altho RAM useage was slightly smaller than 1.19. Thx,

@Zo-Bro-23
Copy link
Contributor

I tried 1.18, 1.17, but the results were the same altho RAM useage was slightly smaller than 1.19. Thx,

Hmm. What about other tools like youtube-dl?

@TheBossMagnus
Copy link

altho RAM useage was slightly smaller than 1.19. Thx

I can confirm, about 100 mb increase from 1.18 to 1.19

@qtotter
Copy link
Author

qtotter commented Jan 12, 2023

Hmm. What about other tools like youtube-dl?

Again, I'm a newbie with these things. YouTube-dl seems powerful, but I haven't gone through "how to use it" yet. YouTube-dl is just a downloader, and you have to encode downloaded files in your favorite format yourself, right?

I don't think the UI part of this app consumes tons of RAM itself, but it eats up RAM once it downloads songs, and never releases memory even after downloads are done...

@Zo-Bro-23
Copy link
Contributor

See here for instructions to download youtube-dl. Then, run this command (if you're on Windows, open Command Prompt and navigate to the folder with the youtube-dl.exe file by running cd FILE_PATH):

youtube-dl --yes-playlist -x --audio-format mp3 --embed-thumbnail --add-metadata --postprocessor-args "-id3v2_version 3" --output "%(title)s.%(ext)s" --playlist-start NUMBER "PLAYLIST_URL"

Replace NUMBER with the playlist index to start from (use 1 if you're unsure about this) and PLAYLIST_URL with the playlist's URL.

This will download the playlist. The reason I'm asking you to do this is because I want to figure out if the issue pertinent to all youtube playlist downloaders or just the youtube-music application.

JellyBrick added a commit to organization/youtube-music-next that referenced this issue Sep 13, 2023
@JellyBrick JellyBrick added the fix-available A fix to the issue is available in a new version label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-available A fix to the issue is available in a new version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants