Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental faster adblocker #1040

Closed
wants to merge 3 commits into from

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Feb 24, 2023

This requires user testing.

Anyone that can test and report how it works for them would be greatly appreciated !

Either clone and build this branch, or download from https:/Zo-Bro-23/youtube-music/releases/tag/v1.19.0

@Lucasamiel0406
Copy link
Contributor

Due to the new dependency update messing with the current plugin, tested this variation to report.

Used it for approximately 3 hours straight, during this time I've seen no ads (including at start) nor bad performance, scrolling feels smooth. At least for me, it's a good replacement for the current plugin.

@Araxeus Araxeus reopened this Apr 27, 2023
@Araxeus
Copy link
Collaborator Author

Araxeus commented Apr 27, 2023

I think i'll add a menu checkbox to the adblocker plugin called beta or experimental which enables this functionality

(since i'm still not 100% sure about this and would like more feedback before completely replacing the current one)

@Lucasamiel0406 Lucasamiel0406 mentioned this pull request May 2, 2023
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work fine, does it also block tracking?

@th-ch
Copy link
Owner

th-ch commented May 12, 2023

Closing this one, implementation has been done in #1134 - thanks for the idea!

@th-ch th-ch closed this May 12, 2023
@Araxeus
Copy link
Collaborator Author

Araxeus commented May 14, 2023

Thanks for finishing this up, I haven't had time to code much lately :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants