Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor providers #125

Merged
merged 8 commits into from
Jan 14, 2021
Merged

Refactor providers #125

merged 8 commits into from
Jan 14, 2021

Conversation

th-ch
Copy link
Owner

@th-ch th-ch commented Jan 12, 2021

This PR follows up recent work by @semvis123 to add providers - it refactors the provider system:

  • splits the original provider in 2 (song controls and info)
  • no autoloading of providers, each plugin loads what is necessary
  • use the controls provider in the shortcuts plugin

…-providers

# By TC (9) and semvis123 (2)
# Via GitHub (4) and semvis123 (1)
* 'master' of github.com:th-ch/youtube-music:
  renamed DiscordRPC to Discord
  Downloader plugin: log audio bitrate
  Disable context isolation (to load ffmpeg wasm)
  Use contextBridge in preload script + update navigation plugin
  Fix downloader plugin with context isolation
  Bump version
  Add portable target to windows builds
  Added Discord rich presence and added extra properties to songinfo provider
  Bump version
  Allow custom audio extensions in downloader
  Defensive: handle null/undefined ffmpeg args
@th-ch th-ch marked this pull request as ready for review January 14, 2021 20:03
@th-ch th-ch merged commit 25fd486 into master Jan 14, 2021
@th-ch th-ch deleted the refactor-providers branch January 14, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant